chore: Fix broken test on Windows #10900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jun 8, 2021
| PathBuf::from(concat!(env!("CARGO_MANIFEST_DIR"))) | ||
| .parent() | ||
| .unwrap() | ||
| .to_path_buf() |
There was a problem hiding this comment.
This just makes the paths that get outputted while the tests are running appear resolved.
dsherret
commented
Jun 8, 2021
cli/tests/089_run_allow_list.ts
Outdated
| cmd: ["cat", "089_run_allow_list.ts"], | ||
| cmd: Deno.build.os === "windows" | ||
| ? ["cmd", "/c", "type", "089_run_allow_list.ts"] | ||
| : ["cat", "089_run_allow_list.ts"], |
There was a problem hiding this comment.
I don't like doing these conditionals. Let me know if you can think of something that exists on all three operating systems by default.
There was a problem hiding this comment.
curl exists on all three now AFAIK. Or maybe echo?
There was a problem hiding this comment.
Oh, echo is good. Thanks!
Edit: Oh, echo isn't an executable, so curl it is! Should be ok for most windows developers (edit: yeah, the edition that introduced curl already reached EOL https://docs.microsoft.com/en-us/windows/release-health/status-windows-10-1803).
Should be ok because last Windows 10 version that was released without curl is now EOL as of last month.
lucacasonato
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catdoes not exist by default on Windows. GitHub actions adds a lot of stuff to the Windows runner to make it work, which is why the CI is ok (I'm often surprised at what works in there).