Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(extensions/crypto): implement randomUUID #10848

Merged
merged 2 commits into from
Jun 5, 2021
Merged

feat(extensions/crypto): implement randomUUID #10848

merged 2 commits into from
Jun 5, 2021

Conversation

crowlKats
Copy link
Member

Closes #10847

caspervonb
caspervonb reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@caspervonb caspervonb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bartlomieju
bartlomieju approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll wait for @lucacasonato approval before landing

lucacasonato
lucacasonato approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :-)

@lucacasonato lucacasonato merged commit cf351f7 into denoland:main Jun 5, 2021
@crowlKats crowlKats deleted the random_uuid branch June 5, 2021 12:49
@bcoe bcoe mentioned this pull request Jun 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb left review comments

@lucacasonato lucacasonato lucacasonato approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement crypto.randomUUID
4 participants
@crowlKats @caspervonb @lucacasonato @bartlomieju