feat(lsp): show hints from deno_lint in addition to messages
#10739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
approved these changes
May 25, 2021
piscisaureus
pushed a commit
that referenced
this pull request
May 31, 2021
piscisaureus
pushed a commit
that referenced
this pull request
May 31, 2021
piscisaureus
pushed a commit
that referenced
this pull request
May 31, 2021
piscisaureus
pushed a commit
that referenced
this pull request
May 31, 2021
piscisaureus
pushed a commit
that referenced
this pull request
May 31, 2021
piscisaureus
pushed a commit
that referenced
this pull request
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the LSP returns only messages from
deno_lint; hints are omitted even when they are.Some lint rules are very unfriendly in the sense that their diagnostic messages give no information about how the lint errors should be addressed properly without having to suppress them.
One example is
ban-ts-commentrule, as its message just tells that the directive is disallowed without comment - when seeing this, one may wonder what "comment" is. While the message is very unclear, the hint is so informative that it gives a concrete example of how to address it, likeAdd an in-line comment explaining the reason for using `@ts-expect-error`, like `// @ts-expect-error: <reason>Therefore, it would be very nice to show not only messages but also hints from
deno_lint. This PR appends hints to messages if any.before
after
