-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli/import_map): Don't statically error on dynamic unmapped bare specifiers #10618
fix(cli/import_map): Don't statically error on dynamic unmapped bare specifiers #10618
Conversation
7042ee4
to
44e9598
Compare
e156127
to
5514e1e
Compare
I'm not entirely sure about this change - it seems to start deviating from the spec algorithm, but on the other hands none of the WPT fail so I guess it's okay. |
Which part deviates from the spec algorithm? The two important changes are:
All other changes are 1-to-1 simplifications e.g. the |
@nayeemrmn I see, somehow I thought spec required to return LGTM then, I will let @kitsonk take a look before landing |
5514e1e
to
d274a90
Compare
Sorry, for some reason this was missing from my todo list... I will look at first thing tomorrow my time. |
d274a90
to
488c003
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #10168.
Fixes #10615.
Fixes #10616.