feat(cli): add location data dir to deno info #10589
Conversation
|
The implementation and tests look good to me 👍 I'm a little worried about the word 'Location data'. Was that documented in our manual? What about 'Web Storage data location' as it only includes web storage data for now |
|
@kt3k maybe 'origin data' would be better? |
|
I changed it to |
Co-authored-by: Nayeem Rahman <[email protected]>
| // TODO(@crowlKats): change to origin_data for 2.0 | ||
| .join("location_data") |
There was a problem hiding this comment.
Do we need to consider this breaking? I feel like we provide cache paths in deno info so we can rename them while providing a stable handle, and this wasn't even in deno info yet.
There was a problem hiding this comment.
well renaming location_data would mean that users that have used local storage would lose their current data
There was a problem hiding this comment.
I think we can still do this in 1.x - we add a "migration" that renames old to new. Lets do this in another PR though.
| // TODO(@crowlKats): change to origin_data for 2.0 | ||
| .join("location_data") |
There was a problem hiding this comment.
I think we can still do this in 1.x - we add a "migration" that renames old to new. Lets do this in another PR though.
Co-authored-by: Luca Casonato <[email protected]>
Co-authored-by: Luca Casonato <[email protected]>
| if location.is_some() { | ||
| println!( | ||
| "{} {:?}", | ||
| colors::bold("Local Storage:"), |
There was a problem hiding this comment.
nit: is this capitalization intentional?
There was a problem hiding this comment.
Yes, as "Local Storage" is a proper noun
|
@crowlKats Thank you for your contribution! |
closes #10585