Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(cli): prefix all op functions with op_ #10463

Merged
merged 1 commit into from
May 2, 2021

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented May 1, 2021

Makes the codebase more searchable and helps distinguish op functions from helper functions

Besides tests/examples/benches this convention appears to be followed everywhere else in the codebase

Makes the codebase more searchable and helps distinguish op functions from helper functions

Besides tests/examples/benches this pattern appears to be used everywhere else in the codebase
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 8905752 into denoland:main May 2, 2021
@AaronO AaronO deleted the cleanup/cli-op-prefix branch May 2, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants