refactor(core): provide builtins as an Extension #10449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronO
force-pushed
the
core/builtin-extension
branch
from
62c5f19
to
61e2f39
Compare
Use core.opAsync() and op_names instead of opcall with a raw op_id This broke, because now that we always load the builtin ops, the OpId==1 assumption was no longer true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treats builtin ops (
op_resources,op_close) and js (core.js,error.js) as a regularJsRuntimeExtensionthat's always loaded (first, see the.insert(0 ...)This guarantees that
op_close,op_resources(andop_printwith #10436) are ready to use afterJsRuntime::newThough builtins are special, they're not "that special", streamlining them will simplify things like moving JS src off heap generically for all extension provided JS without having to treat
core.js,error.jsas edge casesNotes
JsRuntime::newwill no longer have anOpIdof 1 since those builtin ops will have taken those slots. I fixed the tests that relied on that assumption and in general it's strongly discouraged to rely on specific OpIds