Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): convert core.print() to a builtin op #10436

Merged
merged 8 commits into from
May 2, 2021
Merged

refactor(core): convert core.print() to a builtin op #10436

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3fbe176
refactor(core): convert core.print() to a builtin op
AaronO Apr 30, 2021
6d9b2b4
tweak
AaronO Apr 30, 2021
c93960b
tweak
AaronO Apr 30, 2021
e9f4ed1
tweak
AaronO Apr 30, 2021
b43a326
Merge branch 'main' into core/print-op
AaronO May 1, 2021
c852cd9
declare op_print in builtin extension
AaronO May 1, 2021
b834a7e
cli/tsc: fix core.print() usage
AaronO May 1, 2021
018141e
Merge branch 'main' into core/print-op
AaronO May 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
declare op_print in builtin extension
  • Loading branch information
@AaronO
AaronO committed May 1, 2021
commit c852cd926593e54b0dec16dd0bf1d278df730630
3 changes: 1 addition & 2 deletions core/ops_builtin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ pub(crate) fn init_builtins() -> Extension {
))
.ops(vec![
("op_close", op_sync(op_close)),
("op_print", op_sync(op_print)),
("op_resources", op_sync(op_resources)),
])
.build()
Expand Down Expand Up @@ -55,8 +56,6 @@ pub fn op_close(
}

/// Builtin utility to print to stdout/stderr
///
/// This op must be wrapped in `op_sync`.
pub fn op_print(
_state: &mut OpState,
args: (String, bool),
Expand Down