Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): move builtin ops to their own file #10336

Merged
merged 1 commit into from
Apr 25, 2021
Merged

refactor(core): move builtin ops to their own file #10336

merged 1 commit into from
Apr 25, 2021

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Apr 23, 2021 •
edited
Loading

Rationale

  • Cleaner to split builtin ops (op_resources and op_close) and the op internals (in ops.rs)
  • The set of builtin ops will likely grow to include print, encode & decode once serde_v8 has ZeroCopyBuf
  • Once extensions land (core: introduce extensions #9800) it would make sense to bundle these ops as an Extension, we could even include core.js and error.js as a "builtins" extension

bartlomieju
bartlomieju approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 1c71642 into denoland:main Apr 25, 2021
@AaronO AaronO deleted the refactor/core-ops-builtin branch April 25, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AaronO @bartlomieju