refactor(core): simplify error handling #10297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `core.js`: register builtin v8 errors in core.js so consumers don't have to - `core.js`: remove complexity of error args handling (consumers must provide a constructor with custom args, core simply provides msg arg)
Since Error and other builtin error classes are now bootstrapped by core.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies error handling in
core.js. v8 builtin errors are registered by default so new runtimes no longer need to bootstrap with:One less gotcha when bootstrapping runtimes
Changes
core.jsso consumers don't have to(consumers must provide a constructor with custom args, core simply provides msg arg)
99_main.js