Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Windows - deno install shim should use first Deno executable on PATH rather than explictly deno.exe #10247

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Apr 18, 2021

Right now, deno install produces a shim like the following:

% generated by deno install %
@deno.exe "run" "--allow-read" "--allow-write" "--allow-net" "--allow-env" "--allow-run" "--no-check" "https://deno.land/x/deploy/deployctl.ts" %*

This is incorrect because the deno command might not be deno.exe (as is the case on my system where it runs from deno.cmd or deno.ps1 via bvm).

This fix does the following:

  1. It uses the first deno executable on the PATH, so it works the same way as executing the deno command.
  2. It supports more than just a deno.exe executable being on the path.

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@lucacasonato lucacasonato merged commit 0c5ecec into denoland:main Apr 18, 2021
@dsherret dsherret deleted the executableExtensionFix branch April 18, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants