Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(js/http): avoid v8 deopt in async iterator #10160

Merged
merged 2 commits into from
Apr 14, 2021
Merged

perf(js/http): avoid v8 deopt in async iterator #10160

merged 2 commits into from
Apr 14, 2021

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Apr 13, 2021

Previous bailout reason

[bailout (kind: deopt-soft, reason: Insufficient type feedback for generic named access): begin. deoptimizing 0x21fa08605435 <JSFunction next (sfi = 0x21fa0840e5e5)>, opt id 10, bytecode offset 76, deopt exit 2, FP to SP delta 64, caller SP 0x00016b5902b8, pc 0x21fa000901bc]
            ;;; deoptimize at <deno:runtime/js/40_http.js:84:48>

Notes

  • There's still at least another v8 deopt in the http callstack, that I haven't optimized yet

@AaronO
js/http: avoid v8 deopt in async iterator
5a1533b 
bailout (kind: deopt-soft, reason: Insufficient type feedback for generic named access)
ry
ry approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 83f6d4b into denoland:main Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AaronO @ry @bartlomieju