Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime): add stat and statSync methods to Deno.File #10107

Merged
merged 2 commits into from
Apr 12, 2021
Merged

feat(runtime): add stat and statSync methods to Deno.File #10107

merged 2 commits into from
Apr 12, 2021

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Apr 10, 2021 •
edited

Closes #10109

@caspervonb caspervonb changed the title feat(runtime): add stat method to File feat(runtime): add stat and statSync methods to Deno.File Apr 10, 2021
@caspervonb caspervonb force-pushed the feat-runtime-add-stat-to-file branch 3 times, most recently from a329df4 to 63d0cca Compare April 10, 2021 06:31
@caspervonb caspervonb mentioned this pull request Apr 10, 2021
Closed
@caspervonb caspervonb force-pushed the feat-runtime-add-stat-to-file branch from 63d0cca to a7820b5 Compare April 10, 2021 07:35
@caspervonb caspervonb force-pushed the feat-runtime-add-stat-to-file branch from a7820b5 to 7790ca5 Compare April 10, 2021 07:43
@ry
Copy link
Member

ry commented Apr 10, 2021 •
edited

SGTM - anyone have objections?

@kitsonk
Copy link
Contributor

kitsonk commented Apr 10, 2021

SGTM - anyone have objections?

Nope. But I wanted another opinion other than my own.

@caspervonb
Copy link
Contributor Author

caspervonb commented Apr 11, 2021 •
edited

Blocked on #10108 which should be merged first, since this adds directly to the stable File definition and the underlying ops are currently unstable.

bartlomieju
bartlomieju approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit da92193 into denoland:main Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Deno.File.stat and Deno.File.statSync methods
4 participants
@caspervonb @ry @kitsonk @bartlomieju