refactor(op_crates/web): Remove unused code path in TextEncoder #10104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://developer.mozilla.org/en-US/docs/Web/API/TextEncoder, TextEncoder should ignore the "encoding" parameter and always use "utf-8". It seems the current implementation already uses "utf-8" unconditionally. Even if it didn't, a JS implementation of UTF-8 encoding is used, so it is better to leave only the rust implementation which is more efficient.
|
|
kt3k
approved these changes
Apr 11, 2021
There was a problem hiding this comment.
LGTM
Does anyone have any concern? cc @nayeemrmn @lucacasonato @bartlomieju
BTW this condition (this.encoding === "utf-8) was introduced in #3596
lucacasonato
approved these changes
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://developer.mozilla.org/en-US/docs/Web/API/TextEncoder, TextEncoder should ignore the "encoding" parameter and always use "utf-8". It seems the current implementation already uses "utf-8" unconditionally.
Even if it didn't, a JS implementation of UTF-8 encoding is used, so it is better to leave only the rust implementation which is more efficient.