fix(runtime/js/timers): Use (0, eval) instead of eval() #10103

nayeemrmn · 2021-04-10T02:29:42Z

Fixes #10091.

runtime/js/11_timers.js

bnoordhuis

LGTM. One suggestion: maybe add a regression test?

bartlomieju

LGTM

bnoordhuis reviewed Apr 10, 2021

View reviewed changes

runtime/js/11_timers.js Outdated Show resolved Hide resolved

nayeemrmn force-pushed the timers-eval branch from 81ac875 to 36dbab9 Compare April 10, 2021 21:21

nayeemrmn changed the title ~~fix(runtime/js/timers): Use core.evalContext() instead of eval()~~ fix(runtime/js/timers): Use (0, eval) instead of eval() Apr 10, 2021

bnoordhuis approved these changes Apr 11, 2021

View reviewed changes

nayeemrmn force-pushed the timers-eval branch from 36dbab9 to 5c361d3 Compare April 11, 2021 15:57

fix(runtime/js/timers): Use core.evalContext() instead of eval()

014d771

nayeemrmn force-pushed the timers-eval branch from 5c361d3 to 014d771 Compare April 11, 2021 22:08

bartlomieju approved these changes Apr 11, 2021

View reviewed changes

bartlomieju merged commit 8b49d94 into denoland:main Apr 11, 2021

nayeemrmn deleted the timers-eval branch April 11, 2021 23:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(runtime/js/timers): Use (0, eval) instead of eval() #10103

fix(runtime/js/timers): Use (0, eval) instead of eval() #10103

nayeemrmn commented Apr 10, 2021

bnoordhuis left a comment

bartlomieju left a comment

fix(runtime/js/timers): Use (0, eval) instead of eval() #10103

fix(runtime/js/timers): Use (0, eval) instead of eval() #10103

Conversation

nayeemrmn commented Apr 10, 2021

bnoordhuis left a comment

Choose a reason for hiding this comment

bartlomieju left a comment

Choose a reason for hiding this comment