fix(runtime/js/http): Correctly parse user response headers #10076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized we also have no test for non 200 status code 🙃. |
lucacasonato
approved these changes
Apr 8, 2021
bartlomieju
reviewed
Apr 8, 2021
nayeemrmn
force-pushed
the
http-response-headers
branch
3 times, most recently
from
e50d52f
to
1e56c13
Compare
bartlomieju
approved these changes
Apr 11, 2021
Comment on lines
-107
to
-112
| function respond(responseSenderRid, resp, zeroCopyBuf) { | ||
| return Deno.core.jsonOpSync("op_http_response", [ | ||
| responseSenderRid, | ||
| resp.status ?? 200, | ||
| flatEntries(resp.headers ?? {}), | ||
| ], zeroCopyBuf); |
There was a problem hiding this comment.
Glad you removed this function, it was superfluous 👍
nayeemrmn
force-pushed
the
http-response-headers
branch
from
3179ac7
to
d03cf8d
Compare
nayeemrmn
force-pushed
the
http-response-headers
branch
from
d03cf8d
to
7f5f7bb
Compare
ry
reviewed
Apr 12, 2021
|
@ry The following assertion fails on main because no headers from the user's deno/cli/tests/unit/http_test.ts Line 27 in 7f5f7bb |
|
Nayeem - sure that works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a
for ... inloop on aHeadersobject.