Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: build runtime at opt-3 #10072

Merged
merged 5 commits into from
Apr 11, 2021
Merged

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Apr 8, 2021

This PR improves performance by building runtime at opt-3, it adds ~100kb to bin size whilst improving op performance since all ops are registered & wrapped in runtime this helps build more efficient closures, etc...

Benches

Before (main):
date_now:            	n = 500000, dt = 0.029s, r = 17241379/s, t = 58ns/op
perf_now:            	n = 500000, dt = 0.218s, r = 2293578/s, t = 436ns/op
url_parse:           	n = 50000, dt = 0.325s, r = 153846/s, t = 6500ns/op
read_zero:           	n = 500000, dt = 0.328s, r = 1524390/s, t = 656ns/op
write_null:          	n = 500000, dt = 0.324s, r = 1543210/s, t = 648ns/op

After (runtime opt-3):
date_now:            	n = 500000, dt = 0.031s, r = 16129032/s, t = 62ns/op
perf_now:            	n = 500000, dt = 0.174s, r = 2873563/s, t = 348ns/op
url_parse:           	n = 50000, dt = 0.287s, r = 174216/s, t = 5739ns/op
read_zero:           	n = 500000, dt = 0.275s, r = 1818182/s, t = 550ns/op
write_null:          	n = 500000, dt = 0.275s, r = 1818182/s, t = 550ns/op

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 6519f23 into denoland:main Apr 11, 2021
@AaronO AaronO deleted the perf/build-runtime-opt-3 branch April 11, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants