Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unstable): ALPN config in listenTls #10065

Merged
merged 4 commits into from
Apr 10, 2021
Merged

feat(unstable): ALPN config in listenTls #10065

merged 4 commits into from
Apr 10, 2021

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Apr 8, 2021 •
edited
Loading

This commit adds the ability for users to configure ALPN protocols when
calling Deno.listenTls.

Closes #6334.

@lucacasonato
Copy link
Member Author

lucacasonato commented Apr 8, 2021 •
edited
Loading

I am not yet sure how we could test this. It won't be possible to do via unit tests because Deno.connectTls does not expose ALPN protocols. This will likely have to be a rust integration test using a native rustls client, which is relatively unfortunate. Integration tests have been added.

@lucacasonato
feat(unstable): ALPN config in listenTls
a748bfe 
This commit adds the ability for users to configure ALPN protocols when
calling `Deno.listenTls`.
@lucacasonato lucacasonato changed the title feat(unstable): ALPN config in startTls/listenTls feat(unstable): ALPN config in listenTls Apr 9, 2021
@lucacasonato lucacasonato requested a review from ry April 9, 2021 13:32
ry
ry approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests. LGTM

@lucacasonato lucacasonato merged commit 8d55d8b into denoland:main Apr 10, 2021
@lucacasonato lucacasonato deleted the listen_alpn branch April 10, 2021 20:04
@jaclarke jaclarke mentioned this pull request Jul 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS ALPN support
2 participants
@lucacasonato @ry