Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli/compile): Initialize runtime_compiler ops for deno compile #10052

Merged
merged 14 commits into from
Jun 7, 2021
Merged

feat(cli/compile): Initialize runtime_compiler ops for deno compile #10052

merged 14 commits into from
Jun 7, 2021

Conversation

littledivy
Copy link
Member

Closes #10041 This pull request seperates standalone::run logic for denort and deno_cli in a way so that deno_cli could intialize it's own ops.

Title can be improved.

@littledivy littledivy marked this pull request as ready for review April 7, 2021 09:09
@littledivy littledivy changed the title feat(cli/compile): Initialize runtime_compiler ops for "main" binary feat(cli/compile): Initialize runtime_compiler ops for deno compile Apr 7, 2021
@kitsonk kitsonk requested a review from bartlomieju April 7, 2021 09:50
@bartlomieju
Copy link
Member

@ry suggested to remove denort binary completely in #10056; if we were to do that then --lite flag would no longer work and this PR would be a first step towards that.

Let's discuss this PR after releasing 1.9.

@bartlomieju bartlomieju added this to the 1.10.0 milestone Apr 11, 2021
@bartlomieju
Copy link
Member

@littledivy please rebase

@bartlomieju bartlomieju modified the milestones: 1.10.0, 1.11.0 May 19, 2021
@bartlomieju
Copy link
Member

@littledivy this PR looks good to me, can you please add a test case that exercises compiler APIs?

bartlomieju
bartlomieju approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Divy!

@bartlomieju bartlomieju merged commit 8929074 into denoland:main Jun 7, 2021
@littledivy littledivy deleted the compile/emit-op branch June 9, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Optionally support thick binaries for compile
2 participants
@littledivy @bartlomieju