Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): properly handle encoding URLs from lsp client #10033

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Apr 6, 2021

Fixes #9741

@kitsonk kitsonk requested review from ry and lucacasonato April 6, 2021 06:41
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's kind of worrying that we are binding so close to JS because VSCode is the dominant editor.

@kitsonk
Copy link
Contributor Author

kitsonk commented Apr 6, 2021

It's kind of worrying that we are binding so close to JS because VSCode is the dominant editor.

This should work for any editor though, it just widens the situation where the URLs can be "manipulated" by a client, but still have the LSP work properly, versus specifically coupling to VSCode. This should be opaque to other editors.

@kitsonk kitsonk merged commit 2c86ca1 into denoland:main Apr 6, 2021
@kitsonk kitsonk deleted the kitsonk/issue9741 branch April 6, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Goto Type Definition broken for cdn.skypack.dev
2 participants