Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dom.asynciterable seems to have been removed, breaking a module #9881

Closed
ebebbington opened this issue Mar 24, 2021 · 4 comments · Fixed by #9888
Closed

dom.asynciterable seems to have been removed, breaking a module #9881

ebebbington opened this issue Mar 24, 2021 · 4 comments · Fixed by #9888
Assignees
Labels
bug Something isn't working correctly

Comments

@ebebbington
Copy link
Contributor

ebebbington commented Mar 24, 2021

Overview

Was dom.asynciterable removed from the allowed lib options in tsconfig? What was working that used deno 3 releases ago, is broken due to apparently, dom.asynciterable not being a supported lib

$ deno test -A --config .\tsconfig.json

error: TS6046 [ERROR]: Argument for '--lib' option must be: ...

$ cat tsconfig.json

{
  "compilerOptions": {
    "lib": [
      "deno.ns",
      "dom",
      "dom.iterable",
      "dom.asynciterable",
      "es2018"
    ]
  }
}

$

Deno Version

deno 1.8.2
v8 9.0.257.3
typescript 4.2.2
@kitsonk kitsonk added the needs info needs further information to be properly triaged label Mar 25, 2021
@kitsonk
Copy link
Contributor

kitsonk commented Mar 25, 2021

It is still there and there is a test for it: https://github.com/denoland/deno/blob/main/cli/tests/lib_dom_asynciterable.ts

@kitsonk kitsonk added bug Something isn't working correctly and removed needs info needs further information to be properly triaged labels Mar 25, 2021
@kitsonk
Copy link
Contributor

kitsonk commented Mar 25, 2021

Hmmm... not sure why it isn't working now. Investigating.

@kitsonk
Copy link
Contributor

kitsonk commented Mar 25, 2021

@kitsonk kitsonk self-assigned this Mar 25, 2021
kitsonk added a commit to kitsonk/deno that referenced this issue Mar 25, 2021
@ebebbington
Copy link
Contributor Author

Thanks @kitsonk!

kitsonk added a commit that referenced this issue Mar 25, 2021
kitsonk added a commit that referenced this issue Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants