-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test output slightly easier to read #24071
Labels
cli
related to cli/ dir
good first issue
Good for newcomers
suggestion
suggestions for new features (yet to be agreed)
testing
related to deno test and coverage
Comments
My vote is for option #2. In cases where a test has many steps, the user would otherwise have to scroll up to identify the test in question. |
Hi, I can work on this. Do we have decision on the exact fix? |
@hukuuu, I've assigned this task to you. I suggest implementing the first approach, as omitting the repeat test name could make things less easy to follow. From there, we can gather feedback from others. |
nkaradzhov
added a commit
to nkaradzhov/deno
that referenced
this issue
Jun 25, 2024
Indent last line of tests that contain multiple steps.
nkaradzhov
added a commit
to nkaradzhov/deno
that referenced
this issue
Jun 27, 2024
Indent last line of tests that contain multiple steps.
nkaradzhov
added a commit
to nkaradzhov/deno
that referenced
this issue
Jun 28, 2024
Indent last line of tests that contain multiple steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cli
related to cli/ dir
good first issue
Good for newcomers
suggestion
suggestions for new features (yet to be agreed)
testing
related to deno test and coverage
At the moment I find the test output difficult to make quick sense of because it takes the following shape:
I would personally find this easier to read if it were formatted as follows instead:
The below illustrates how it currently looks and an alternative approach where the closing line of the test is also printed darker so that it's easier to scan through the tests:
![image](https://private-user-images.githubusercontent.com/554215/335826183-a7c52f89-32dd-4086-80b5-59d071e4dcbb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyMjMwOTYsIm5iZiI6MTcyMTIyMjc5NiwicGF0aCI6Ii81NTQyMTUvMzM1ODI2MTgzLWE3YzUyZjg5LTMyZGQtNDA4Ni04MGI1LTU5ZDA3MWU0ZGNiYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxN1QxMzI2MzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ZTc5NTVhNzJmMGY2YTQyM2I1YjNkMGZjYjYwNjhmNjIxNmIyNTI0MGQ0NTcwYzlhY2RmYjU4ZGRiMTJhOGJiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.vOPV9sduQUyPrUQojpulD-LNZcAYLJpr2-9_XSO67eY)
![image](https://private-user-images.githubusercontent.com/554215/335826189-55a99cf5-b3d0-49ac-b0ce-8788c4c6a739.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyMjMwOTYsIm5iZiI6MTcyMTIyMjc5NiwicGF0aCI6Ii81NTQyMTUvMzM1ODI2MTg5LTU1YTk5Y2Y1LWIzZDAtNDlhYy1iMGNlLTg3ODhjNGM2YTczOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxN1QxMzI2MzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02ZDU2NDZlMjVkMTdhODA5MWY1MGUwNzQ2Y2QxM2RmMTY5NThhOWIxYWM3MjQxMTc1OGUzNTZjYzU0NjIxZDA3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.eSmJf8H5OPOqiSvRuHIdBsrFDnAKcFnkiQC-UbNGU08)
Perhaps the repeat of the test name could be removed entirely?
Note: This was originally posted in the Discord channel but re-posting here as requested :)
The text was updated successfully, but these errors were encountered: