-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deno task build
failures in node_modules/.deno/[email protected]/node_modules/fs-extra/lib/util/stat.js
#22180
Labels
bug
Something isn't working correctly
needs investigation
requires further investigation before determining if it is an issue or not
node compat
Comments
@littledivy looks related to https://github.com/denoland/deno/pull/21986/files |
Seems we can't use
|
littledivy
added a commit
that referenced
this issue
Feb 1, 2024
Fixes #22180 Matches the Node.js implementation more closely. Removed types, they do not help just make it harder to debug with stack traces.
littledivy
added a commit
that referenced
this issue
Feb 1, 2024
Fixes #22180 Matches the Node.js implementation more closely. Removed types, they do not help just make it harder to debug with stack traces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working correctly
needs investigation
requires further investigation before determining if it is an issue or not
node compat
Version: Deno 1.40.2
I apologize for not being able to find a clean example to share. We're trying to update Quarto's bundled deno to 1.40.2 and we've run into a bit of trouble. We have an auxiliary TSC project that we've been building with
deno task build
in v1.37.2 without a problem. In v1.40.2, though, we see the following stack trace:(I replaced the TSC project root with
<PROJECT_ROOT>
to make the stack trace easier to read.)I've been unable to track down exactly why this succeeds in 1.37.2 and fails in 1.40.2. The problem is deterministic inside the Quarto source tree, so I have a simple but very unclean reproduction I'll share below share. But I haven't been able to deterministically trigger the problem outside the tree. Different invocations of the same
deno
binary will cause the crash to happen, while other times it doesn't.I don't expect you to want to track down the full repro, but in case you do:
git clone https://github.com/quarto-dev/quarto-cli.git; cd quarto-cli; ./configure.sh
git clone https://github.com/quarto-dev/quarto-cli.git; cd quarto-cli; git checkout chore/1.5-dependency-refresh; ./configure.sh
The actual sub-project is
src/webui/quarto-preview
, which is built (eventually) throughdeno task build
.If you have a hunch of what might be causing this, I'm more than happy to help you come up with a minimal reproduction. I'm just a bit lost of where to proceed from here.
Thank you!
The text was updated successfully, but these errors were encountered: