-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in node:zlib
polyfill in Deno v1.32.3
#19540
Labels
Comments
I just verified with the latest canary and zlib dictionaries are working again. Thanks a lot! <3 |
danopia
added a commit
to cloudydeno/deno-spdy_transport
that referenced
this issue
Aug 14, 2023
This reverts commit e1885e0. Deno merged a fix: * denoland/deno#19540 (comment) Should land in v1.36.2.
No problem, and sorry for breaking it 😓 |
littledivy
added a commit
to littledivy/deno
that referenced
this issue
Aug 21, 2023
littledivy
added a commit
that referenced
this issue
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dictionary
parameter is not accepted anymore when setting up zlib.createDeflate
andcreateInflate
.Minimal reproduction, with zero-length dictionary:
Also I noticed that Deno only allows
Buffer
instances fordictionary
. As per nodejs docs,Uint8Array
is accepted since node v8.0 andArrayBuffer
since node v9.4. So perhaps the polyfill should accept them too.The text was updated successfully, but these errors were encountered: