Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP errors very agressively on files containing data: url imports #18524

Closed
lucacasonato opened this issue Mar 31, 2023 · 0 comments · Fixed by #18527
Closed

LSP errors very agressively on files containing data: url imports #18524

lucacasonato opened this issue Mar 31, 2023 · 0 comments · Fixed by #18527
Assignees
@dsherret
Labels
bug Something isn't working correctly lsp related to the language server

Comments

@lucacasonato
Copy link
Member

lucacasonato commented Mar 31, 2023 •
edited 

import {} from "data:application/typescript,42";
import "data:application/javascript,export%20const%20value%20%3D%2069%3B";
import _a from "data:application/typescript,export default { 0: 1 };";
import _b from "data:application/typescript;base64,ZXhwb3J0IGRlZmF1bHQgMHhERUFEQkVFRg==";
import { Nani } from "data:application/javascript,export const Nani = '何'";

image

The errors are emitted any time any file is changed in the project, after this source is loaded into tsc.
@lucacasonato lucacasonato added bug Something isn't working correctly lsp related to the language server labels Mar 31, 2023
@dsherret dsherret self-assigned this Mar 31, 2023
@dsherret dsherret mentioned this issue Mar 31, 2023
Merged
dsherret added a commit that referenced this issue Mar 31, 2023
@dsherret
fix(lsp): better handling of data: urls (#18527)
87ccd4b 
1. Log instead of error when the referrer can't be found
2. Fixes typescript to resolve data urls correctly. Properly documented
here:
https://github.com/denoland/TypeScript/pull/4/files#diff-180da7c288743d11d8590d30f0c07c48e5dcf291aa671bbea0dd520a9a1359d2

Closes #18524
mmastrac pushed a commit that referenced this issue Mar 31, 2023
@dsherret @mmastrac
fix(lsp): better handling of data: urls (#18527)
cd7071b 
1. Log instead of error when the referrer can't be found
2. Fixes typescript to resolve data urls correctly. Properly documented
here:
https://github.com/denoland/TypeScript/pull/4/files#diff-180da7c288743d11d8590d30f0c07c48e5dcf291aa671bbea0dd520a9a1359d2

Closes #18524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsherret dsherret

Labels
bug Something isn't working correctly lsp related to the language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lsp): better handling of data: urls dsherret/deno
2 participants
@dsherret @lucacasonato