Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add microbenchmarks for ext/webidl #17436

Closed
littledivy opened this issue Jan 15, 2023 · 0 comments · Fixed by #17435
Closed

Add microbenchmarks for ext/webidl #17436

littledivy opened this issue Jan 15, 2023 · 0 comments · Fixed by #17435
Labels
benchmarks https://deno.land/benchmarks.html perf performance related

Comments

@littledivy
Copy link
Member

We do not have a microbenchmark we can point contributors to run. See PRs #16407 and #16594

webidl is in a lot of hot path so its important that we do not regress there.
@littledivy littledivy added perf performance related benchmarks https://deno.land/benchmarks.html labels Jan 15, 2023
@littledivy littledivy mentioned this issue Jan 15, 2023
Merged
littledivy added a commit that referenced this issue Jan 15, 2023
@littledivy
chore(ext/webidl): Add dictionary converter microbenchmark (#17435)
8f321a8 
This commits add a `webidl.createDictionaryConverter` converter
microbenchmark.

There are 2 PRs currently open that need a microbenchmark for webidl
dictionary converter. See #16594
and #16407

Closes #17436
bartlomieju pushed a commit that referenced this issue Jan 16, 2023
@littledivy @bartlomieju
chore(ext/webidl): Add dictionary converter microbenchmark (#17435)
7f65a5d 
This commits add a `webidl.createDictionaryConverter` converter
microbenchmark.

There are 2 PRs currently open that need a microbenchmark for webidl
dictionary converter. See #16594
and #16407

Closes #17436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmarks https://deno.land/benchmarks.html perf performance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ext/webidl): Add dictionary converter microbenchmark littledivy/deno
1 participant
@littledivy