Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno repl hangs without network access #16426

Open
mhio opened this issue Oct 26, 2022 · 2 comments · May be fixed by #17364
Open

deno repl hangs without network access #16426

mhio opened this issue Oct 26, 2022 · 2 comments · May be fixed by #17364
Labels
bug Something isn't working correctly repl related to the Read-Eval-Print-Loop functionality of Deno

Comments

@mhio
Copy link

mhio commented Oct 26, 2022

Running the repl in 1.25.4 and 1.26.2 in a debian:11 container hangs when there's no network access.

There are connection attempts to deno.land / tcp / 443, that seem to do a retry backoff which takes a couple of minutes

$ date; docker run -ti me/deno /deno repl --eval 'console.log(new Date())'
Wed 26 Oct 2022 01:45:56 UTC

2022-10-26T01:48:07.230Z
Deno 1.25.4
exit using ctrl+d or close()
>

I think it might be related to the connections being dropped rather than getting an ICMP response.

The --no-remote options don't seem to affect whatever is loading.

Could the remote lookups be disabled optionally? Is there a way to pre cache the remote lookup?
@mhio
Copy link
Author

mhio commented Oct 26, 2022

Is it the completions that are trying to load?

deno/cli/lsp/repl.rs

Lines 302 to 306 in 4d166e6

imports: ImportCompletionSettings {
auto_discover: false,
hosts: HashMap::from([("https://deno.land".to_string(), true)]),
},
},

@dsherret dsherret added bug Something isn't working correctly repl related to the Read-Eval-Print-Loop functionality of Deno labels Oct 26, 2022
@bartlomieju
Copy link
Member

@dsherret should we add a timeout here and continue if completion setting can't be obtained?

@crowlKats crowlKats linked a pull request Jan 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly repl related to the Read-Eval-Print-Loop functionality of Deno
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lsp): timeout registry config fetching after 10 seconds crowlKats/deno
3 participants
@dsherret @bartlomieju @mhio