Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsp: quick fixes using full URLs for new imports #15330

Closed
iugo opened this issue Jul 28, 2022 · 1 comment · Fixed by #19692
Closed

lsp: quick fixes using full URLs for new imports #15330

iugo opened this issue Jul 28, 2022 · 1 comment · Fixed by #19692
Assignees
@kitsonk
Labels
bug Something isn't working correctly lsp related to the language server

Comments

@iugo
Copy link
Contributor

iugo commented Jul 28, 2022

Is your feature request related to a problem? Please describe.

When using import map, quick fix's add import from still tries to write the full URL instead of using import map.

Describe the solution you'd like

When the add import from function of quick fix is triggered, it will be automatically matched according to the import map, and an additional option will be given after matching.
@kitsonk kitsonk transferred this issue from denoland/vscode_deno Jul 28, 2022
@kitsonk kitsonk changed the title Feature: quick fix add import map support lsp: quick fixes using full URLs for new imports Jul 28, 2022
@kitsonk kitsonk added bug Something isn't working correctly lsp related to the language server labels Jul 28, 2022
@kitsonk kitsonk self-assigned this Jul 28, 2022
@kitsonk
Copy link
Contributor

kitsonk commented Jul 28, 2022

Technically this shouldn't be happening, it should be coming in with the import completion already remapped.

@bartlomieju bartlomieju mentioned this issue Mar 15, 2023
Open
@nayeemrmn nayeemrmn mentioned this issue Mar 17, 2023
Closed
@dsherret dsherret mentioned this issue Jul 3, 2023
Merged
dsherret added a commit that referenced this issue Jul 3, 2023
@dsherret
feat(lsp): support import maps in quick fix and auto-imports (#19692)
e8a866c 
Closes denoland/vscode_deno#849
Closes #15330
Closes #10951
Closes #13623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsonk kitsonk

Labels
bug Something isn't working correctly lsp related to the language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lsp): support import maps in quick fix and auto-imports dsherret/deno
2 participants
@iugo @kitsonk