Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version_bump should run the format command to format the Releases.md #14739

Closed
kitsonk opened this issue May 27, 2022 · 1 comment · Fixed by #14743 or #14784
Closed

version_bump should run the format command to format the Releases.md #14739

kitsonk opened this issue May 27, 2022 · 1 comment · Fixed by #14743 or #14784
Assignees
Labels
build build system or continuous integration related feat new feature (which has been agreed to/accepted)

Comments

@kitsonk
Copy link
Contributor

kitsonk commented May 27, 2022

I had a version_bump generated PR fail CI because the Releases.md needed to be formatted because of rather long commit messages. The process should run formatting as part of generating the PR.

@kitsonk kitsonk added build build system or continuous integration related feat new feature (which has been agreed to/accepted) labels May 27, 2022
@dsherret
Copy link
Member

Looks to be recent because of updates in the format script. I'll add an unstable flag:

error: Uncaught TypeError: Deno.spawn is not a function
  const { status } = await Deno.spawn(execPath, {
                                ^
    at dprint (file:https:///home/runner/work/deno/deno/tools/format.js:8:33)
    at main (file:https:///home/runner/work/deno/deno/tools/format.js:20:9)
    at async file:https:///home/runner/work/deno/deno/tools/format.js:41:1
Error: Error executing deno. Code: 1
    at runCommandWithOutput (https://raw.githubusercontent.com/denoland/automation/0.11.0/helpers.ts:47:11)
    at async updateReleasesMd (file:https:///home/runner/work/deno/deno/tools/release/01_bump_crate_versions.ts:55:3)
    at async file:https:///home/runner/work/deno/deno/tools/release/01_bump_crate_versions.ts:37:3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build system or continuous integration related feat new feature (which has been agreed to/accepted)
Projects
None yet
2 participants