Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsp: not showing X-Deno-Warning as a diagnostic #13472

Closed
kitsonk opened this issue Jan 23, 2022 · 0 comments · Fixed by #13554
Closed

lsp: not showing X-Deno-Warning as a diagnostic #13472

kitsonk opened this issue Jan 23, 2022 · 0 comments · Fixed by #13554
Assignees
@kitsonk
Labels
bug Something isn't working correctly lsp related to the language server

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Jan 23, 2022

At some point when we were refactoring things, this was lost, because the language sever never accesses the "pre-redirected" warning header, only the final redirected specifier's header which doesn't contain the value.
@kitsonk kitsonk added the bug Something isn't working correctly label Jan 23, 2022
@kitsonk kitsonk self-assigned this Jan 23, 2022
@kitsonk kitsonk added the lsp related to the language server label Jan 23, 2022
kitsonk added a commit to kitsonk/deno that referenced this issue Feb 1, 2022
@kitsonk
fix(lsp): properly display x-deno-warning with redirects
987846e 
Fixes: denoland#13472
@kitsonk kitsonk mentioned this issue Feb 1, 2022
Merged
kitsonk added a commit to kitsonk/deno that referenced this issue Feb 2, 2022
@kitsonk
fix(lsp): properly display x-deno-warning with redirects
22cb044 
Fixes: denoland#13472
kitsonk added a commit that referenced this issue Feb 2, 2022
@kitsonk
fix(lsp): properly display x-deno-warning with redirects (#13554)
26f5c22 
Fixes: #13472
ry pushed a commit to ry/deno that referenced this issue Feb 3, 2022
@kitsonk @ry
fix(lsp): properly display x-deno-warning with redirects (denoland#13554
0a3ff97 
)

Fixes: denoland#13472
ry pushed a commit to ry/deno that referenced this issue Feb 3, 2022
@kitsonk @ry
fix(lsp): properly display x-deno-warning with redirects (denoland#13554
aa06c43 
)

Fixes: denoland#13472
bartlomieju pushed a commit that referenced this issue Feb 3, 2022
@kitsonk @bartlomieju
fix(lsp): properly display x-deno-warning with redirects (#13554)
9d71457 
Fixes: #13472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsonk kitsonk

Labels
bug Something isn't working correctly lsp related to the language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lsp): properly display x-deno-warning with redirects kitsonk/deno
1 participant
@kitsonk