Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users can set "Host" header for fetch #11017

Closed
lucacasonato opened this issue Jun 17, 2021 · 4 comments · Fixed by #11020
Closed

Users can set "Host" header for fetch #11017

lucacasonato opened this issue Jun 17, 2021 · 4 comments · Fixed by #11020
Labels
bug Something isn't working correctly ext/fetch related to the ext/fetch

Comments

@lucacasonato
Copy link
Member

The host header should not be able to be set by the user. It should always be populated by reqwest / hyper.
@lucacasonato lucacasonato added bug Something isn't working correctly ext/fetch related to the ext/fetch labels Jun 17, 2021
@lucacasonato lucacasonato mentioned this issue Jun 17, 2021
Closed
@zlumyo zlumyo mentioned this issue Jun 17, 2021
Merged
@nayeemrmn
Copy link
Collaborator

Ref #6868.

@xdatcloud
Copy link

Hi there, I'm not familiar with background info about this issue, but it is possible to send request to endpoint behind Kubernetes Ingress with customized host header: https://kubernetes.io/docs/concepts/services-networking/ingress/#ingress-rules .

@PoneyClairDeLune PoneyClairDeLune mentioned this issue Jul 20, 2022
Open
@crowlKats crowlKats mentioned this issue Sep 9, 2022
Closed
@kitsonk kitsonk mentioned this issue Sep 9, 2022
Closed
@Tc-001 Tc-001 mentioned this issue Nov 26, 2022
Closed
@LucienLeMagicien LucienLeMagicien mentioned this issue Feb 27, 2023
Closed
@tlgimenes
Copy link

Guys, can we have a solution to passing host header? Any ideas on how to implement a transparent proxy with Deno's fetch?

@crowlKats crowlKats mentioned this issue Jun 27, 2023
Closed
@guifromrio
Copy link

We're being forced to use CF workers to proxy requests because of this limitation. Would be great for it to just work on deno.

@crowlKats crowlKats mentioned this issue Jul 3, 2023
Merged
bartlomieju pushed a commit that referenced this issue Jul 28, 2023
@crowlKats
feat: Deno.createHttpClient allowHost (#19689)
5cb1d18 
This adds an option to allow using the host header in a fetch call.
Closes #16840
Ref #11017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly ext/fetch related to the ext/fetch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(extensions/fetch): Filter out custom HOST headers zlumyo/deno
5 participants
@guifromrio @tlgimenes @lucacasonato @nayeemrmn @xdatcloud