fix: decoding uri in file_server (#3187)

denoland · Dec 10, 2019 · 31ddfd5 · 31ddfd5
1 parent ec7f3ce
commit 31ddfd5
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/std/http/file_server.ts b/std/http/file_server.ts
@@ -285,10 +285,10 @@ listenAndServe(
   addr,
   async (req): Promise<void> => {
     const normalizedUrl = posix.normalize(req.url);
-    const fsPath = posix.join(target, normalizedUrl);
+    const decodedUrl = decodeURIComponent(normalizedUrl);
+    const fsPath = posix.join(target, decodedUrl);
 
     let response: Response;
-
     try {
       const info = await stat(fsPath);
       if (info.isDirectory()) {

diff --git a/std/http/file_server_test.ts b/std/http/file_server_test.ts
@@ -79,3 +79,17 @@ test(async function serveFallback(): Promise<void> {
     killFileServer();
   }
 });
+
+test(async function serveFallback(): Promise<void> {
+  await startFileServer();
+  try {
+    const res = await fetch(
+      "https://localhost:4500/http/testdata/test%20file.txt"
+    );
+    assert(res.headers.has("access-control-allow-origin"));
+    assert(res.headers.has("access-control-allow-headers"));
+    assertEquals(res.status, 200);
+  } finally {
+    killFileServer();
+  }
+});
diff --git a/std/http/testdata/test file.txt b/std/http/testdata/test file.txt