Skip to content

Commit

Permalink
test(op_crates/web): add regression tests for past URL bugs (#9639) (#…
Browse files Browse the repository at this point in the history
…9639)

Closes: #9383
  • Loading branch information
piscisaureus committed Mar 2, 2021
1 parent 79c198f commit 1f47bdd
Showing 1 changed file with 26 additions and 1 deletion.
27 changes: 26 additions & 1 deletion cli/tests/unit/url_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
// Copyright 2018-2021 the Deno authors. All rights reserved. MIT license.
import { assert, assertEquals, assertThrows, unitTest } from "./test_util.ts";
import {
assert,
assertEquals,
assertStrictEquals,
assertThrows,
unitTest,
} from "./test_util.ts";

unitTest(function urlParsing(): void {
const url = new URL(
Expand Down Expand Up @@ -470,3 +476,22 @@ unitTest(function emptyPortForSchemeDefaultPort(): void {
url2.protocol = "http";
assertEquals(url2.port, "");
});

unitTest(function assigningPortPropertyAffectsReceiverOnly() {
// Setting `.port` should update only the receiver.
const u1 = new URL("http:https://google.com/");
// deno-lint-ignore no-explicit-any
const u2 = new URL(u1 as any);
u2.port = "123";
assertStrictEquals(u1.port, "");
assertStrictEquals(u2.port, "123");
});

unitTest(function urlSearchParamsIdentityPreserved() {
// URLSearchParams identity should not be lost when URL is updated.
const u = new URL("http:https://foo.com/");
const sp1 = u.searchParams;
u.href = "http:https://bar.com/?baz=42";
const sp2 = u.searchParams;
assertStrictEquals(sp1, sp2);
});

0 comments on commit 1f47bdd

Please sign in to comment.