Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: additive global context for npm packages (first pass) #1

Open
wants to merge 15 commits into
base: branch_v4.8.3
Choose a base branch
from
Open

feat: additive global context for npm packages (first pass) #1

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ed3da83
feat: separate node and deno global contexts
dsherret Oct 4, 2022
a22ce84
Expose non-@types/node globals to deno code
dsherret Oct 4, 2022
d417132
Opt-in instead of opt-out
dsherret Oct 5, 2022
8beebda
Back to ES5
dsherret Oct 5, 2022
a90a3d0
Fix iterator TypeError in proxy.
dsherret Oct 5, 2022
d6dfd05
Get ambient modules based on source file.
dsherret Oct 5, 2022
82a6d53
Fix cache.
dsherret Oct 6, 2022
c32df33
Fix ambient module lookup.
dsherret Oct 6, 2022
bc68095
Keep these in the node code.
dsherret Oct 6, 2022
b9ceae0
Resolve npm package references to the ambient module when not found.
dsherret Oct 7, 2022
8e8c37b
Update.
dsherret Oct 17, 2022
962fba0
Add manual changes already made in deno repo
dsherret Oct 17, 2022
b0a7e5e
Revert pr change
dsherret Oct 21, 2022
3ed9eee
Allow synthetic default imports in esm
dsherret Oct 27, 2022
d56d1e1
Support npm package references with leading `/`
dsherret Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Support npm package references with leading /
  • Loading branch information
@dsherret
dsherret committed Nov 22, 2022
commit d56d1e156a3055dec315e5bc8a33df96b572d4d3
8 changes: 6 additions & 2 deletions src/compiler/deno.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ namespace ts.deno {
if (!text.startsWith("npm:")) {
throw new Error(`Not an npm specifier: ${text}`);
}
text = text.replace(/^npm:/, "");
text = text.replace(/^npm:\/?/, "");
const parts = text.split("/");
const namePartLen = text.startsWith("@") ? 2 : 1;
if (parts.length < namePartLen) {
Expand All @@ -207,8 +207,12 @@ namespace ts.deno {
versionReq = lastNamePart.substring(lastAtIndex + 1);
nameParts[nameParts.length - 1] = lastNamePart.substring(0, lastAtIndex);
}
const name = nameParts.join("/");
if (name.length === 0) {
throw new Error(`Npm specifier did not have a name: ${text}`);
}
return {
name: nameParts.join("/"),
name,
versionReq,
subPath: parts.length > nameParts.length ? parts.slice(nameParts.length).join("/") : undefined,
};
Expand Down