Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for db-djv-pg operations under Git control #55

Closed
denis-stepanov opened this issue Nov 5, 2022 · 1 comment · Fixed by #74
Closed

Support for db-djv-pg operations under Git control #55

denis-stepanov opened this issue Nov 5, 2022 · 1 comment · Fixed by #74
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@denis-stepanov
Copy link
Owner

Some db-djv-pg commands, such as export or rename modify the file system. Any serious database snapshot would normally be under version control. Hence, it would be nice that the tool informs Git of the changes made (i.e., stages the change), so that the user would not need to retrofit them manually (which could be a bit tricky, like in the case of rename). It is suggested to add --git flag to such commands (not active by default) which would call the relevant Git commands whenever needed.

@denis-stepanov denis-stepanov added the enhancement New feature or request label Nov 5, 2022
@denis-stepanov denis-stepanov added this to the v1.6.0 milestone Dec 22, 2022
@denis-stepanov denis-stepanov self-assigned this Apr 15, 2024
@denis-stepanov denis-stepanov linked a pull request Apr 24, 2024 that will close this issue
@denis-stepanov
Copy link
Owner Author

Done, with the following remarks:

  1. instead of --git, an autodetect of git repo is implemented, and a reverse option --no-git provided to inhibit it
  2. only rename is currently affected, and it will do git mv, edit followed by git add. export will create new unstaged files which corresponds to regular git behavior wrt new files. delete currently does not support file operations, so no action. Other commands do not modify file system
  3. rename operation will print STAGED on successful run indicating that git has been informed of the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant