Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] CSV Feed - Content Pack Update #30710

Conversation

xsoar-bot
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@chrking-paloaltonetworks

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Nov 7, 2023
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_chrking-paloaltonetworks-contrib-FeedCSV November 7, 2023 05:02
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @ilappe will very shortly look over your proposed changes.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution, please ask the reviewer to update your information in the pack contributors file. See more information here link

Copy link
Contributor

@ilappe ilappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chrking-paloaltonetworks for the contribution!
please see my few comments

Packs/FeedCSV/pack_metadata.json Outdated Show resolved Hide resolved
Packs/FeedCSV/ReleaseNotes/1_2_0.md Outdated Show resolved Hide resolved
@ilappe ilappe added the pending-contributor The PR is pending the response of its creator label Nov 7, 2023
Copy link
Contributor

@ilappe ilappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ilappe ilappe added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. docs-approved labels Nov 8, 2023
@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6829644

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6829645

@ilappe ilappe merged commit 12b4aa4 into demisto:contrib/xsoar-contrib_chrking-paloaltonetworks-contrib-FeedCSV Nov 8, 2023
24 of 27 checks passed
DeanArbel pushed a commit that referenced this pull request Nov 8, 2023
…30745)

* "contribution update to pack "CSV Feed""

* Update Packs/FeedCSV/pack_metadata.json



* Rename 1_2_0.md to 1_1_29.md

* revert changes in CSVFeedApiModule.py

to avoid lint issues

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: Christian King <[email protected]>
Co-authored-by: Israel Lappe <[email protected]>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
…30745)

* "contribution update to pack "CSV Feed""

* Update Packs/FeedCSV/pack_metadata.json



* Rename 1_2_0.md to 1_1_29.md

* revert changes in CSVFeedApiModule.py

to avoid lint issues

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: Christian King <[email protected]>
Co-authored-by: Israel Lappe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Thank you! Contributions are always welcome! docs-approved External PR pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants