Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add packs.json to the build #26975

Merged
merged 8 commits into from
May 28, 2023
Merged

add packs.json to the build #26975

merged 8 commits into from
May 28, 2023

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented May 24, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@ilaner ilaner requested a review from daryakoval as a code owner May 28, 2023 08:44
@ilaner ilaner requested a review from esharf as a code owner May 28, 2023 09:17
@@ -35,6 +35,7 @@
if [[ $TEST_UPLOAD == "false" ]]; then
section_start "Upload content graph GraphML to GCP" --collapsed
gsutil cp $ARTIFACTS_FOLDER/content_graph/$MARKETPLACE_VERSION.zip "gs:https://$GCS_MARKET_BUCKET_DEV/content_graph/$MARKETPLACE_VERSION.zip"
gsutil cp $ARTIFACTS_FOLDER/packs.json "gs:https://$GCS_MARKET_BUCKET_DEV/content_graph/$MARKETPLACE_VERSION_packs.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a note to describe there it's used

@@ -52,11 +52,20 @@ def create_dependencies(content_dto: ContentDTO, is_bucket_upload: bool, output:
json.dump(pack_dependencies, f, indent=4)


def create_packs_json(content_dto: ContentDTO, packs_output: Path):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a docstring

@ilaner ilaner merged commit 9568dbc into master May 28, 2023
@ilaner ilaner deleted the export_packs_json branch May 28, 2023 19:14
israelpoli pushed a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants