fix(wasm): Fixes deps for building in wasm #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A while ago we made sure that if you wanted to pull in the base bindle types into something compiling to wasm, it would build. Recently, tokio made a change that made it so it wouldn't compile for wasm with the `fs` feature enabled. This makes sense, but I did have to untangle some fs stuff from the signatures module. While I was here I fixed a bunch of new clippy lints from the latest version of clippy Signed-off-by: Taylor Thomas <[email protected]>
vdice
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago we made sure that if you wanted to pull in the base bindle types into something compiling to wasm, it would build. Recently, tokio made a change that made it so it wouldn't compile for wasm with the
fsfeature enabled. This makes sense, but I did have to untangle some fs stuff from the signatures module.While I was here I fixed a bunch of new clippy lints from the latest version of clippy