Fix for crate consumers not finding Signature trait methods #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radu-matei
approved these changes
Jan 31, 2022
thomastaylor312
approved these changes
Jan 31, 2022
|
Tested and looking good! Signing and server refresh (re-verification of invoices) all appear as expected. |
vdice
approved these changes
Jan 31, 2022
This was referenced Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue when consuming the
bindlecrate in WAGI (and, no doubt, other applications): theed25519_dalek::Signature::from_bytes, used ininvoice/signature.rsandinvoice/verification.rs, method is actually on thesignature::Signaturetrait which is not in scope in those files. I don't yet understand why those files would compile in the Bindle client and server, but they don't compile in WAGI. And adding the trait to the files makes them give an "unused import" warning in Bindle!The fix is to instead use Signature's
TryFromimplementation, which is documented in the Signature examples, doesn't need to be brought into scope, and delegates directly tofrom_bytesso shouldn't change any behaviour #famouslastwords.@vdice would be great if you could give this a test please - I'm not sure how to exercise the signature stuff. Thanks!