fix(*): Fixes various clippy lints

deislabs · Jan 26, 2022 · 2bc895b · 2bc895b
1 parent 3de704c
commit 2bc895b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 15 deletions.
diff --git a/bin/client/main.rs b/bin/client/main.rs
@@ -570,11 +570,7 @@ fn role_from_name(name: String) -> Result<SignatureRole> {
 
 async fn first_matching_key(fpath: PathBuf, role: &SignatureRole) -> Result<SecretKeyEntry> {
  let keys = SecretKeyFile::load_file(&fpath).await.map_err(|e| {
- ClientError::Other(format!(
- "Error loading file {}: {}",
- fpath.display(),
- e.to_string()
- ))
+ ClientError::Other(format!("Error loading file {}: {}", fpath.display(), e))
  })?;
 
  keys.get_first_matching(role)

diff --git a/src/client/mod.rs b/src/client/mod.rs
@@ -276,11 +276,10 @@ impl<T: tokens::TokenManager> Client<T> {
  {
  let parsed_id = id.try_into().map_err(|e| e.into())?;
  tracing::span::Span::current().record("invoice_id", &tracing::field::display(&parsed_id));
- let req = self.client.delete(self.base_url.join(&format!(
- "{}/{}",
- INVOICE_ENDPOINT,
- parsed_id.to_string()
- ))?);
+ let req = self.client.delete(
+ self.base_url
+ .join(&format!("{}/{}", INVOICE_ENDPOINT, parsed_id))?,
+ );
  let req = self.token_manager.apply_auth_header(req).await?;
  trace!(?req);
  let resp = req.send().await?;
@@ -461,9 +460,7 @@ impl<T: tokens::TokenManager> Client<T> {
  tracing::span::Span::current().record("invoice_id", &tracing::field::display(&parsed_id));
  let req = self.client.get(self.base_url.join(&format!(
  "{}/{}/{}",
- RELATIONSHIP_ENDPOINT,
- "missing",
- parsed_id.to_string()
+ RELATIONSHIP_ENDPOINT, "missing", parsed_id
  ))?);
  let req = self.token_manager.apply_auth_header(req).await?;
  trace!(?req);

diff --git a/src/client/tokens.rs b/src/client/tokens.rs
@@ -223,8 +223,8 @@ impl OidcToken {
 
  println!(
  "Open this URL in your browser:\n{}\nand then enter the code when prompted: {}",
- device_code_details.verification_uri().to_string(),
- device_code_details.user_code().secret().to_string()
+ **device_code_details.verification_uri(),
+ device_code_details.user_code().secret()
  );
 
  let oauth_client: Oauth2Client<