Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: utility function for docstore deserialization #8226

Merged
merged 4 commits into from
Aug 14, 2024
Merged

refactor: utility function for docstore deserialization #8226

merged 4 commits into from
Aug 14, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • Introduce a utility function to perform this common operation
  • test it properly

How did you test it?

CI, new tests

Checklist

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Aug 14, 2024
@anakin87 anakin87 marked this pull request as ready for review August 14, 2024 10:11
@anakin87 anakin87 requested review from a team as code owners August 14, 2024 10:11
@anakin87 anakin87 requested review from dfokina, davidsbatista and shadeMe and removed request for a team and davidsbatista August 14, 2024 10:11
@coveralls
Copy link
Collaborator

coveralls commented Aug 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10386461988

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 90.134%
Files with Coverage Reduction New Missed Lines %
components/retrievers/sentence_window_retriever.py 7 79.55%
Totals Coverage Status
Change from base Build 10384533702: 0.05%
Covered Lines: 6943
Relevant Lines: 7703
💛 - Coveralls

@anakin87 anakin87 requested a review from shadeMe August 14, 2024 11:14
@shadeMe shadeMe merged commit bcc4104 into main Aug 14, 2024
17 checks passed
@shadeMe shadeMe deleted the refactor-ds-deserialization branch August 14, 2024 11:29
anakin87 added a commit that referenced this pull request Aug 14, 2024
@anakin87
refactor: utility function for docstore deserialization (#8226)
2dae417 
* refactor docstore deserialization

* more tests

* reno; headers

* expose key
@anakin87 anakin87 mentioned this pull request Aug 14, 2024
Merged
shadeMe pushed a commit that referenced this pull request Aug 14, 2024
@anakin87
Cherry-pick docstores deserialization refactoring to 2.4.x (#8227)
34e2412 
* fix: deserialize Document Stores using specific `from_dict` class methods (#8207)

* use from_dict

* unused import

* improve logic

* improve reno

* refactor: utility function for docstore deserialization (#8226)

* refactor docstore deserialization

* more tests

* reno; headers

* expose key
@anakin87 anakin87 mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @shadeMe