chore: fix HTMLToDocument test
#8127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
commented
Jul 31, 2024
| @@ -161,21 +162,23 @@ def test_serde(self): | |||
| assert new_converter.extraction_kwargs == converter.extraction_kwargs | |||
|
|
|||
| def test_run_difficult_html(self, test_files_path): | |||
| # boilerpy3's DefaultExtractor fails to extract text from this HTML file | |||
There was a problem hiding this comment.
unrelated: removed an outdated comment
silvanocerza
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
https://github.com/deepset-ai/haystack/actions/runs/10176181855/job/28145024482
A new version of Trafilatura was released, where the extraction parameters are still valid but the extraction is handled a bit differently.
Proposed Changes:
Transform the test into a real unit test: we now check that Trafilatura is called with the right parameters and not the extraction result
How did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.