-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add AnswerJoiner
new component
#8122
Conversation
Pull Request Test Coverage Report for Build 10196642167Details
💛 - Coveralls |
Looking for some early feedback before I wrap up @sjrl |
Hey @vblagoje as long as the custom join function is specifiable in a yaml file then I'm all aboard making it easy to extend in the future. |
So @vblagoje if you could add a test for |
AnswerJoiner
new component
@sjrl while I'm on PTO please feel free to move this one forward, anyone else welcome as well 🙏 |
Hey @Amnah199 I'd really appreciate your review on this, since I've made some changes so it feels odd for me to approve my own work 😅 |
Co-authored-by: Amna Mubashar <[email protected]>
Hey @dfokina could you look over the doc strings to check if this okay with the recent effort of rehauling doc strings for components? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you for tagging me @sjrl , going over it now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstrings updated
Why:
Adds an
AnswerJoiner
to merge multiple lists of answers using various join modes, addressing the need for simplified answer aggregation.What:
AnswerJoiner
class inhaystack/components/joiners/answer_joiner.py
for merging lists of answers.haystack/components/joiners/__init__.py
to includeAnswerJoiner
in the module exports.test/components/joiners/test_answer_joiner.py
to validate the functionality ofAnswerJoiner
.How can it be used:
How did you test it:
Notes for the reviewer:
JoinMode
enumeration inanswer_joiner.py
to ensure future proofing for additional join modes._concatenate
method for performance implications with large lists.