Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated TGI generators #7908

Merged
merged 2 commits into from
Jun 21, 2024
Merged

chore: remove deprecated TGI generators #7908

merged 2 commits into from
Jun 21, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

remove deprecated TGI generators

How did you test it?

CI

Checklist

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Jun 20, 2024
anakin87
anakin87 commented Jun 20, 2024
View reviewed changes
haystack/utils/hf.py
@@ -212,27 +212,6 @@ def resolve_hf_pipeline_kwargs(
return huggingface_pipeline_kwargs


def list_inference_deployed_models(headers: Optional[Dict] = None) -> List[str]:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function was only used in TGI generators and did not work as expected, restricting too much the available models

@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9601007716

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 90.216%
Files with Coverage Reduction New Missed Lines %
utils/hf.py 17 84.0%
Totals Coverage Status
Change from base Build 9600865720: 0.05%
Covered Lines: 6823
Relevant Lines: 7563
💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review June 21, 2024 08:15
@anakin87 anakin87 requested review from a team as code owners June 21, 2024 08:15
@anakin87 anakin87 requested review from dfokina and vblagoje and removed request for a team June 21, 2024 08:15
@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9610493641

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 90.214%
Files with Coverage Reduction New Missed Lines %
utils/hf.py 20 83.89%
Totals Coverage Status
Change from base Build 9600865720: 0.04%
Covered Lines: 6822
Relevant Lines: 7562
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9610496120

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 90.214%
Files with Coverage Reduction New Missed Lines %
utils/hf.py 20 83.89%
Totals Coverage Status
Change from base Build 9600865720: 0.04%
Covered Lines: 6822
Relevant Lines: 7562
💛 - Coveralls

vblagoje
vblagoje approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiice 🚀

@anakin87 anakin87 merged commit c59ad95 into main Jun 21, 2024
31 checks passed
@anakin87 anakin87 deleted the rm-tgi-generators branch June 21, 2024 09:15
@anakin87 anakin87 mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anakin87 @coveralls @vblagoje