Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated TEI embedders #7907

Merged
merged 4 commits into from
Jun 21, 2024
Merged

chore: remove deprecated TEI embedders #7907

merged 4 commits into from
Jun 21, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

remove deprecated TEI embedders

How did you test it?

CI

Checklist

@github-actions github-actions bot added the type:documentation Improvements on the docs label Jun 20, 2024
@anakin87 anakin87 marked this pull request as ready for review June 20, 2024 16:14
@anakin87 anakin87 requested review from a team as code owners June 20, 2024 16:14
@anakin87 anakin87 requested review from dfokina and shadeMe and removed request for a team June 20, 2024 16:14
@anakin87 anakin87 marked this pull request as draft June 20, 2024 16:20
@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9601039669

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 90.048%
Totals Coverage Status
Change from base Build 9596818530: -0.1%
Covered Lines: 6904
Relevant Lines: 7667
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9601128623

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 90.048%
Totals Coverage Status
Change from base Build 9600865720: -0.1%
Covered Lines: 6904
Relevant Lines: 7667
💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review June 21, 2024 08:06
@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9610371382

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 90.048%
Totals Coverage Status
Change from base Build 9600865720: -0.1%
Covered Lines: 6904
Relevant Lines: 7667
💛 - Coveralls

@anakin87 anakin87 merged commit 75ad76a into main Jun 21, 2024
31 checks passed
@anakin87 anakin87 deleted the rm-deprecated-tei-embedders branch June 21, 2024 08:36
@anakin87 anakin87 mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anakin87 @coveralls @shadeMe