Move utility functions from _enqueue_next_runnable_component
#7895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadeMe
approved these changes
Jun 20, 2024
silvanocerza
added a commit
that referenced
this pull request
Jun 26, 2024
silvanocerza
added a commit
that referenced
this pull request
Jul 12, 2024
shadeMe
added a commit
that referenced
this pull request
Jul 12, 2024
* Move utility functions from _enqueue_next_runnable_component (#7895) * Isolate logic to check if we're stuck in a loop * Simplify for else * Add missing return in docstring * Emit warning when stuck in a loop * Fix docstring Co-authored-by: Madeesh Kannan <[email protected]> * Add utility function to move Components in queues * Add function to find next Component to run * Comment update * Add missing break in loop * Make _add_missing_input_defaults less error prone and add tests * Fix tests * Update docstring * Simplify enqueue logic * Remove unused _enqueue_next_runnable_component function * Add method to find Component with lazy variadic input or all inputs with defaults * Simplify _find_next_runnable_lazy_variadic_or_default_component * Remove unnecessary type ignore * Split _dequeue_components_that_received_no_input into separate functions * Fix linting * Simplify variadic check when running Component * Simplify code * Reorganize functions used by Pipeline.run * Rename variables used in Pipeline.run() for clarity * Add comment clarifying last_waiting_queue and before_last_waiting_queue * Add functions to easily update waiting_queue --------- Co-authored-by: Madeesh Kannan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Part of #7614
Proposed Changes:
Move the following functions out of
_enqueue_next_runnable_component:_is_lazy_variadic_has_all_inputs_with_defaults_add_missing_input_defaultsThey're going to be used in other functions.
How did you test it?
Ran tests locally.
Notes for the reviewer
N/A
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.