feat: `EvaluationRunResult` add parameter to specify columns to keep in the comparative `Dataframe` #7879

davidsbatista · 2024-06-17T11:45:08Z

Proposed Changes:

Allow the user to specify specify columns to keep in the comparative Dataframe

How did you test it?

Run local unit tests

Checklist

I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
I documented my code
I ran pre-commit hooks and fixed any issue

coveralls · 2024-06-17T11:51:55Z

Pull Request Test Coverage Report for Build 9547073146

Details

0 of 0 changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.003%) to 89.746%

Files with Coverage Reduction	New Missed Lines	%
evaluation/eval_run_result.py	4	92.42%

Totals
Change from base Build 9544797751:	0.003%
Covered Lines:	6923
Relevant Lines:	7714

💛 - Coveralls

coveralls · 2024-06-17T11:59:00Z

Pull Request Test Coverage Report for Build 9547147359

Details

0 of 0 changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.003%) to 89.746%

Files with Coverage Reduction	New Missed Lines	%
evaluation/eval_run_result.py	4	92.42%

Totals
Change from base Build 9544797751:	0.003%
Covered Lines:	6923
Relevant Lines:	7714

💛 - Coveralls

shadeMe

LGTM!

haystack/evaluation/eval_run_result.py

releasenotes/notes/add-keep-columns-to-EvalRunResult-comparative-be3e15ce45de3e0b.yaml

Co-authored-by: Madeesh Kannan <[email protected]>

…ve-be3e15ce45de3e0b.yaml Co-authored-by: Madeesh Kannan <[email protected]>

coveralls · 2024-06-17T15:46:44Z

Pull Request Test Coverage Report for Build 9550619663

Details

0 of 0 changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.003%) to 89.746%

Files with Coverage Reduction	New Missed Lines	%
evaluation/eval_run_result.py	4	92.42%

Totals
Change from base Build 9550292209:	0.003%
Covered Lines:	6923
Relevant Lines:	7714

💛 - Coveralls

coveralls · 2024-06-17T15:47:12Z

Pull Request Test Coverage Report for Build 9550621579

Details

0 of 0 changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.003%) to 89.746%

Files with Coverage Reduction	New Missed Lines	%
evaluation/eval_run_result.py	4	92.42%

Totals
Change from base Build 9550292209:	0.003%
Covered Lines:	6923
Relevant Lines:	7714

💛 - Coveralls

coveralls · 2024-06-17T15:47:22Z

Pull Request Test Coverage Report for Build 9550623950

Details

0 of 0 changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.003%) to 89.746%

Files with Coverage Reduction	New Missed Lines	%
evaluation/eval_run_result.py	4	92.42%

Totals
Change from base Build 9550292209:	0.003%
Covered Lines:	6923
Relevant Lines:	7714

💛 - Coveralls

coveralls · 2024-06-17T15:51:54Z

Pull Request Test Coverage Report for Build 9550688665

Details

0 of 0 changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.003%) to 89.746%

Files with Coverage Reduction	New Missed Lines	%
evaluation/eval_run_result.py	4	92.42%

Totals
Change from base Build 9550292209:	0.003%
Covered Lines:	6923
Relevant Lines:	7714

💛 - Coveralls

enable ruff format and re-format outdated files feat: `EvaluationRunResult` add parameter to specify columns to keep in the comparative `Dataframe` (#7879) * adding param to explictily state which cols to keep * adding param to explictily state which cols to keep * adding param to explictily state which cols to keep * updating tests * adding release notes * Update haystack/evaluation/eval_run_result.py Co-authored-by: Madeesh Kannan <[email protected]> * Update releasenotes/notes/add-keep-columns-to-EvalRunResult-comparative-be3e15ce45de3e0b.yaml Co-authored-by: Madeesh Kannan <[email protected]> * updating docstring --------- Co-authored-by: Madeesh Kannan <[email protected]> add format-check fail on format and linting failures fix string formatting reformat long lines fix tests fix typing linter pull from main

* ruff settings enable ruff format and re-format outdated files feat: `EvaluationRunResult` add parameter to specify columns to keep in the comparative `Dataframe` (#7879) * adding param to explictily state which cols to keep * adding param to explictily state which cols to keep * adding param to explictily state which cols to keep * updating tests * adding release notes * Update haystack/evaluation/eval_run_result.py Co-authored-by: Madeesh Kannan <[email protected]> * Update releasenotes/notes/add-keep-columns-to-EvalRunResult-comparative-be3e15ce45de3e0b.yaml Co-authored-by: Madeesh Kannan <[email protected]> * updating docstring --------- Co-authored-by: Madeesh Kannan <[email protected]> add format-check fail on format and linting failures fix string formatting reformat long lines fix tests fix typing linter pull from main * reformat * lint -> check * lint -> check

davidsbatista added 4 commits June 17, 2024 12:59

adding param to explictily state which cols to keep

a02f804

adding param to explictily state which cols to keep

fb476cc

adding param to explictily state which cols to keep

8fcb3cc

updating tests

1efee69

davidsbatista requested a review from a team as a code owner June 17, 2024 11:45

davidsbatista requested review from anakin87 and removed request for a team June 17, 2024 11:45

github-actions bot added topic:tests type:documentation Improvements on the docs labels Jun 17, 2024

Merge branch 'main' into fix/evaluation_run_result_comparative_dataframe

90c3c35

davidsbatista changed the title ~~fix: EvaluationRunResult add parameter to specify columns to keep in the comparative Dataframe~~ feat: EvaluationRunResult add parameter to specify columns to keep in the comparative Dataframe Jun 17, 2024

adding release notes

e9ab026

davidsbatista requested a review from a team as a code owner June 17, 2024 11:51

davidsbatista requested review from dfokina and removed request for a team June 17, 2024 11:51

davidsbatista requested a review from shadeMe June 17, 2024 15:17

shadeMe approved these changes Jun 17, 2024

View reviewed changes

haystack/evaluation/eval_run_result.py Outdated Show resolved Hide resolved

releasenotes/notes/add-keep-columns-to-EvalRunResult-comparative-be3e15ce45de3e0b.yaml Outdated Show resolved Hide resolved

davidsbatista and others added 4 commits June 17, 2024 17:39

Update haystack/evaluation/eval_run_result.py

ba6f0f1

Co-authored-by: Madeesh Kannan <[email protected]>

Update releasenotes/notes/add-keep-columns-to-EvalRunResult-comparati…

ef06b32

…ve-be3e15ce45de3e0b.yaml Co-authored-by: Madeesh Kannan <[email protected]>

Merge branch 'main' into fix/evaluation_run_result_comparative_dataframe

0adb743

updating docstring

5688a2b

davidsbatista merged commit 55513f7 into main Jun 17, 2024
17 checks passed

davidsbatista deleted the fix/evaluation_run_result_comparative_dataframe branch June 17, 2024 16:08

davidsbatista mentioned this pull request Jul 3, 2024

comparative_individual_scores_report should keep the results of the two pipelines being compared #7969

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: `EvaluationRunResult` add parameter to specify columns to keep in the comparative `Dataframe` #7879

feat: `EvaluationRunResult` add parameter to specify columns to keep in the comparative `Dataframe` #7879

davidsbatista commented Jun 17, 2024

coveralls commented Jun 17, 2024 •

edited

Loading

coveralls commented Jun 17, 2024 •

edited

Loading

shadeMe left a comment

coveralls commented Jun 17, 2024 •

edited

Loading

coveralls commented Jun 17, 2024 •

edited

Loading

coveralls commented Jun 17, 2024 •

edited

Loading

coveralls commented Jun 17, 2024 •

edited

Loading

feat: EvaluationRunResult add parameter to specify columns to keep in the comparative Dataframe #7879

feat: EvaluationRunResult add parameter to specify columns to keep in the comparative Dataframe #7879

Conversation

davidsbatista commented Jun 17, 2024

Proposed Changes:

How did you test it?

Checklist

coveralls commented Jun 17, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9547073146

Details

💛 - Coveralls

coveralls commented Jun 17, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9547147359

Details

💛 - Coveralls

shadeMe left a comment

Choose a reason for hiding this comment

coveralls commented Jun 17, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9550619663

Details

💛 - Coveralls

coveralls commented Jun 17, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9550621579

Details

💛 - Coveralls

coveralls commented Jun 17, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9550623950

Details

💛 - Coveralls

coveralls commented Jun 17, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9550688665

Details

💛 - Coveralls

feat: `EvaluationRunResult` add parameter to specify columns to keep in the comparative `Dataframe` #7879

feat: `EvaluationRunResult` add parameter to specify columns to keep in the comparative `Dataframe` #7879

coveralls commented Jun 17, 2024 •

edited

Loading

coveralls commented Jun 17, 2024 •

edited

Loading

coveralls commented Jun 17, 2024 •

edited

Loading

coveralls commented Jun 17, 2024 •

edited

Loading

coveralls commented Jun 17, 2024 •

edited

Loading

coveralls commented Jun 17, 2024 •

edited

Loading