Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pin numpy<2; tenacity!=8.4.0 #7876

Merged
merged 3 commits into from
Jun 17, 2024
Merged

chore: pin numpy<2; tenacity!=8.4.0 #7876

merged 3 commits into from
Jun 17, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Several failures in core integrations: Chroma, Fastembed, Optimum and Qdrant.

Proposed Changes:

Pin numpy<2

How did you test it?

CI

Checklist

@anakin87 anakin87 marked this pull request as ready for review June 17, 2024 07:38
@anakin87 anakin87 requested review from a team as code owners June 17, 2024 07:38
@anakin87 anakin87 requested review from dfokina, julian-risch and silvanocerza and removed request for a team and julian-risch June 17, 2024 07:38
@coveralls
Copy link
Collaborator

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9543779532

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.743%
Totals Coverage Status
Change from base Build 9518891629: 0.0%
Covered Lines: 6921
Relevant Lines: 7712
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9543772661

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.743%
Totals Coverage Status
Change from base Build 9518891629: 0.0%
Covered Lines: 6921
Relevant Lines: 7712
💛 - Coveralls

@anakin87
Copy link
Member Author

anakin87 commented Jun 17, 2024 •
edited
Loading

I'm also pinning tenacity!=8.4.0 (#7877)

@anakin87 anakin87 changed the title chore: pin numpy<2 chore: pin numpy<2; tenacity!=8.4.0 Jun 17, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9544466185

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.743%
Totals Coverage Status
Change from base Build 9518891629: 0.0%
Covered Lines: 6921
Relevant Lines: 7712
💛 - Coveralls

@anakin87 anakin87 merged commit 2413bb3 into main Jun 17, 2024
17 checks passed
@anakin87 anakin87 deleted the pin-numpy branch June 17, 2024 08:54
@anakin87 anakin87 mentioned this pull request Jun 17, 2024
Closed
silvanocerza pushed a commit that referenced this pull request Jun 17, 2024
@anakin87 @silvanocerza
chore: pin numpy<2; tenacity!=8.4.0 (#7876)
0e112dd 
* pin numpy<2

* reno

* pin tenacity too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:build/distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anakin87 @coveralls @silvanocerza