fix: enable tracing upon import / improve logging setup #7859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
requested review from
dfokina,
vblagoje and
masci
and removed request for
a team
github-actions
bot
added
topic:tests
type:documentation
wochinge
commented
Jun 14, 2024
| @@ -330,6 +331,7 @@ def configure_logging(use_json: Optional[bool] = None) -> None: | |||
| structlog.stdlib.add_log_level, | |||
| # Adds the current timestamp in ISO format to logs | |||
| structlog.processors.TimeStamper(fmt="iso"), | |||
| structlog.contextvars.merge_contextvars, | |||
There was a problem hiding this comment.
simple additions and improve the usability of the default configuration
Pull Request Test Coverage Report for Build 9512845635Details
💛 - Coveralls |
faymarie
reviewed
Jun 14, 2024
| @@ -13,6 +14,9 @@ | |||
| # This is a no-op unless `structlog` is installed | |||
| haystack.logging.configure_logging() | |||
|
|
|||
| # Same for tracing (no op if `opentelemetry` or `ddtrace` is not installed) | |||
| haystack.tracing.auto_enable_tracing() | |||
faymarie
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.