Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up default env and add a script to generate release notes. #7858

Merged
merged 6 commits into from
Jun 14, 2024
Merged

chore: clean up default env and add a script to generate release notes. #7858

merged 6 commits into from
Jun 14, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented Jun 14, 2024 •
edited
Loading

Related Issues

No issue

Proposed Changes:

  • Add a new hatch script hatch run release-notes my-release-note
  • Clean up the default environment
  • Remove black usage in favor of ruff
  • Amend the contributions guidelines accordingly

How did you test it?

Notes for the reviewer

Checklist

@masci masci requested review from a team as code owners June 14, 2024 07:19
@masci masci requested review from dfokina and Amnah199 and removed request for a team June 14, 2024 07:19
@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jun 14, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9512882831

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.64%
Totals Coverage Status
Change from base Build 9511870582: 0.0%
Covered Lines: 6896
Relevant Lines: 7693
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9515633102

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.64%
Totals Coverage Status
Change from base Build 9511870582: 0.0%
Covered Lines: 6896
Relevant Lines: 7693
💛 - Coveralls

@masci masci merged commit 324bbc3 into main Jun 14, 2024
22 checks passed
@masci masci deleted the massi/reno branch June 14, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@Amnah199 Amnah199 Awaiting requested review from Amnah199 Amnah199 is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:CI topic:DX Developer Experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masci @coveralls @silvanocerza